OCPNODE-2358: Update (cluster)imagepolicy doc no restriction on release repo scopes #1927
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@QiWang19: This pull request references OCPNODE-2358 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @QiWang19! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/M
|
/test verify |
|
@JoelSpeed @deads2k could you review? The documented restriction was removed from the implementation to support openshift/enhancements#1633. This PR will keep the doc up to date. |
|
@QiWang19: This pull request references OCPNODE-2358 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mtrmac PTAL |
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
ACK in the sense that this matches the MCO change.
I’ve previously demonstrated to be ignorant of k8s API rules, so I’d prefer experts to review this PR :)
QiWang19
force-pushed
the
clusterimagepolicy-doc
branch
from
60c4818 to
c75f6f4
Compare
openshift-ci
bot
added
size/L
QiWang19
force-pushed
the
clusterimagepolicy-doc
branch
from
c75f6f4 to
a2e6c8d
Compare
|
@mtrmac Added the doc about the longest path match and warning information about the openshift repository. |
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
The note about matching the most specific scope is definitely valuable.
Update the (Cluster)imagepolicy docs to stay compatible with the implementation change Signed-off-by: Qi Wang <[email protected]>
QiWang19
force-pushed
the
clusterimagepolicy-doc
branch
from
a2e6c8d to
d7b7087
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, QiWang19, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@QiWang19: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.17.0-202407041312.p0.g33ed71a.assembly.stream.el9 for distgit ose-cluster-config-api. |
6 participants
openshift/machine-config-operator#4401 implementation removes the restriction that
scopesfield can not be set for OCP release payload repo to support openshift/enhancements#1633.Remove the godoc comment from (Cluster)imagepolicy docs to stay compatible with the implementation of this change.